[FIX] [RPC] Align getrawtransaction with Bitcoin Core by moisesPompilio · Pull Request #985 · getfloresta/Floresta

moisesPompilio · 2026-04-23T02:35:16Z

Description and Notes

Brings Floresta’s getrawtransaction RPC closer to Bitcoin Core compatibility.

Fixes the RPC method call so the client correctly uses getrawtransaction instead of the incorrect gettransaction, and standardizes verbosity handling to match Bitcoin Core’s numeric behavior.

The response format was aligned with Bitcoin Core as well:

RawTx fields such as blockhash, confirmations, blocktime, and time are now optional and only serialized when present.
txid encoding was corrected.
TxOut.value now uses f64 in BTC instead of u64 in sats, matching Bitcoin Core’s denomination.
TxOut.address is now optional and only included when the script can be converted into a valid address.
TxIn now handles coinbase inputs properly, including the coinbase field only when applicable.
ASM formatting was improved to follow Bitcoin Core’s rules more strictly.
TxOut script types were expanded to cover the script types supported by Bitcoin Core.

Note: the desc field was intentionally left out, since matching Bitcoin Core’s descriptor logic requires additional investigation and a more complex implementation. That can be handled in a future PR.

How to verify the changes you have done?

Compare the output of getrawtransaction between Floresta and Bitcoin Core for both verbosity = 0 and verbosity = 1.

The integration test added here already covers this behavior and is the best reference for validation.

Check regular transactions across multiple script types, including P2PKH, P2WPKH, P2SH, and P2TR.
Check coinbase transactions and confirm the special input/output fields are handled correctly.
Review the optional field behavior to ensure fields are only present when they should be.
Inspect the integration test to confirm field-by-field validation against Bitcoin Core.

moisesPompilio · 2026-04-23T02:41:21Z

This PR is in draft because it depends on #821. That PR introduces typos for spell checking, allowing more flexibility when using randomly generated addresses without triggering spelling errors

moisesPompilio · 2026-05-15T02:20:16Z

22e29a2 I rebased and converted the added integration test to the pytest format.

jaoleal · 2026-05-15T14:30:31Z

-    #[command(name = "gettransaction")]
-    GetTransaction { txid: Txid, verbose: Option<bool> },
+    #[command(name = "getrawtransaction")]
+    GetRawTransaction { txid: Txid, verbose: Option<u32> },


I dont think that Bitcoin Core will appear with 4 294 967 295 levels of verbosity

I agree, but u32 is the default for numeric verbosity that we use.

u32 occupies too much space for something simple as a verbosity level.

Also: #1076

I replaced the u32 with a u8.

jaoleal · 2026-05-15T14:31:17Z

+        match verbosity {
+            0 => serde_json::to_value(serialize_hex(&tx.tx))
+                .map_err(|e| JsonRpcError::Decode(e.to_string())),
+            1 => serde_json::to_value(self.make_raw_transaction(tx))
+                .map_err(|e| JsonRpcError::Decode(e.to_string())),
+            _ => return Err(JsonRpcError::InvalidVerbosityLevel),
+        }
    }


Return a structured type instead of a generic

jaoleal · 2026-05-15T14:41:01Z


+/// The information returned by a get_raw_tx
 #[derive(Deserialize, Serialize)]
 pub struct RawTxJson {


Did you tried to use corepc ?

Because the GetRawTransaction of corepc is not good, the coinbase field of the input is missing, and in addition, old fields are present.

Davidson-Souza · 2026-05-20T13:16:48Z

nit: the bang (!) should come before the column (:) in your commit titles. fix(rpc)!:

Davidson-Souza

first code review

Davidson-Souza · 2026-05-20T13:21:12Z

+        if verbosity > 1 {
+            return Err(JsonRpcError::InvalidVerbosityLevel);
        }


03bae40

nit: Since there's a wildcard inside the match below, this check is useless.

Yeah, I didn’t want the verbosity check to be after getting the transaction, but it doesn’t really matter, since it would only save a few milliseconds in the process. So I removed this if; the validation is in the match now.

Davidson-Souza · 2026-05-20T13:24:56Z

+pub enum GetRawTransactionRes {
+    Zero(String),
+
+    One(Box<RawTxJson>),
+}


b07a232

nit:

Suggested change

pub enum GetRawTransactionRes {

Zero(String),

One(Box<RawTxJson>),

}

pub enum GetRawTransactionRes {

Zero(String),

One(Box<RawTxJson>),

}

Also, you Box-ed it because it is too big?

Yes, we are adopting Box for the response enums because the verbosity objects tend to be very large.

Davidson-Souza · 2026-05-20T15:54:10Z

+}
+
+/// The information returned by a get_raw_tx
+#[derive(Debug, Deserialize, Serialize)]


b07a232

Suggested change

#[derive(Debug, Deserialize, Serialize)]

#[derive(Debug, Deserialize, Serialize)]

/// The information returned by a get_raw_tx

jaoleal

ACK 7331f65

Davidson-Souza · 2026-06-02T15:36:14Z

Needs rebase

…osity to numeric type The RPC client was incorrectly calling 'gettransaction' (which doesn't exist on the server) instead of 'getrawtransaction'. Additionally, the verbosity parameter handling was inconsistent. While the method signature correctly accepted Option<u32>, it needed better standardization to match Bitcoin Core's RPC specification.

…format This commit aligns the getrawtransaction RPC response with Bitcoin Core's format and behavior. The following changes were made: RawTx struct: - Made blockhash, confirmations, blocktime, and time optional fields They are now only serialized when present, avoiding null values - Fixed txid encoding that was previously inverted TxOut struct: - Changed value from u64 (sats) to f64 (BTC) for proper denomination - Made address field optional, only serialized when script can be converted to a valid address TxIn struct: - Added coinbase field that only appears in coinbase transactions, containing the hex-encoded script from scriptSig - Coinbase inputs have: coinbase, sequence, witness (optional) - Regular inputs have: txid, vout, script_sig, sequence, witness (optional) Script handling: - Improved ASM (assembly) format conversion to strictly follow Bitcoin Core rules and formatting standards TxOut types: - Updated to include all script types that Bitcoin Core supports Note: The `desc` field was not implemented due to complex matching rules. This will be added in a future PR.

Add comprehensive integration test comparing Floresta's `getrawtransaction` RPC output with Bitcoin Core for verbosity levels 0 and 1, covering: - Regular transactions (`P2PKH`, `P2WPKH`, `P2SH`, `P2TR types`) - Coinbase transactions - Input/output field validation - Optional field handling New BaseRPC methods: - `get_raw_transaction()` New BitcoinRPC methods: - `create_wallet()` - `get_new_address()` - `generate_block_to_wallet()` - `send_to_address()`

moisesPompilio · 2026-06-04T14:56:18Z

d0b8750 I’ve rebased

moisesPompilio force-pushed the get_raw_transaction branch from 044b3b7 to 6099cc1 Compare April 23, 2026 02:40

moisesPompilio self-assigned this Apr 23, 2026

moisesPompilio added the ecosystem support Enable interoperability, compatibility and practical integration with the broader Bitcoin ecosystem label Apr 23, 2026

moisesPompilio added this to Floresta Apr 23, 2026

github-project-automation Bot moved this to Backlog in Floresta Apr 23, 2026

moisesPompilio moved this from Backlog to In progress in Floresta Apr 23, 2026

moisesPompilio mentioned this pull request Apr 23, 2026

[Enhancement] Add output script to descriptor converter (Bitcoin Core compliant) #987

Open

jaoleal self-requested a review April 23, 2026 10:46

moisesPompilio force-pushed the get_raw_transaction branch 3 times, most recently from 9547e4a to c9ac410 Compare May 15, 2026 01:55

moisesPompilio marked this pull request as ready for review May 15, 2026 01:59

moisesPompilio force-pushed the get_raw_transaction branch from c9ac410 to 22e29a2 Compare May 15, 2026 02:03

jaoleal moved this from In progress to Needs review in Floresta May 15, 2026

jaoleal reviewed May 15, 2026

View reviewed changes

csgui added this to the Q2/2026 milestone May 18, 2026

moisesPompilio force-pushed the get_raw_transaction branch from 22e29a2 to d67326e Compare May 19, 2026 18:34

Davidson-Souza requested changes May 20, 2026

View reviewed changes

moisesPompilio force-pushed the get_raw_transaction branch from d67326e to 7331f65 Compare May 21, 2026 15:57

jaoleal approved these changes May 21, 2026

View reviewed changes

jaoleal requested a review from Davidson-Souza May 25, 2026 14:02

moisesPompilio mentioned this pull request Jun 1, 2026

Electrum blockchain.transaction.get ignores the verbose argument (breaks Blue Wallet) #1107

Open

moisesPompilio added 4 commits June 4, 2026 10:18

docs(rpc): add documentation for getrawtransaction RPC

d0b8750

moisesPompilio force-pushed the get_raw_transaction branch from 7331f65 to d0b8750 Compare June 4, 2026 14:53

Davidson-Souza requested a review from jaoleal June 5, 2026 13:09

	#[derive(Debug, Deserialize, Serialize)]
	#[derive(Debug, Deserialize, Serialize)]
	/// The information returned by a get_raw_tx

Conversation

moisesPompilio commented Apr 23, 2026

Description and Notes

How to verify the changes you have done?

Uh oh!

moisesPompilio commented Apr 23, 2026

Uh oh!

moisesPompilio commented May 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Davidson-Souza commented May 20, 2026

Uh oh!

Davidson-Souza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaoleal left a comment

Choose a reason for hiding this comment

Uh oh!

Davidson-Souza commented Jun 2, 2026

Uh oh!

moisesPompilio commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants